-
Notifications
You must be signed in to change notification settings - Fork 1
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: adds BLS signature verification for provider registration #523
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ckartik
changed the title
feat: adds BLS signature verification for provider registration.
feat: adds BLS signature verification for provider registration
Dec 9, 2024
mrekucci
approved these changes
Dec 9, 2024
chrmatt
previously requested changes
Dec 9, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Verifying the BLS key is a good step! I suggest to not just sign the address though, as discussed in more detail below.
mrekucci
requested changes
Dec 11, 2024
* chore: add errors to verification * chore: add errors to verification * chore: add errors to verification --------- Co-authored-by: Alok <[email protected]>
ckartik
force-pushed
the
ckartik/add-bls-vericiation-use-sc
branch
from
December 12, 2024 18:28
f1077a9
to
1fa0d65
Compare
mrekucci
force-pushed
the
ckartik/add-bls-vericiation-use-sc
branch
from
December 12, 2024 20:46
b6cc895
to
8dfd1f7
Compare
mrekucci
force-pushed
the
ckartik/add-bls-vericiation-use-sc
branch
from
December 12, 2024 21:31
8dfd1f7
to
d139bad
Compare
mrekucci
force-pushed
the
ckartik/add-bls-vericiation-use-sc
branch
2 times, most recently
from
December 13, 2024 12:57
f20cfc2
to
5bad8f6
Compare
mrekucci
force-pushed
the
ckartik/add-bls-vericiation-use-sc
branch
from
December 13, 2024 13:21
5bad8f6
to
48646d7
Compare
mrekucci
approved these changes
Dec 13, 2024
ckartik
dismissed
chrmatt’s stale review
December 13, 2024 18:25
Will improve signed payload in subsequent versions.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR introduces updates to the smart contracts, testing infrastructure, and other components impacting provider flow, registration, and staking processes:
Provider Registration:
Protobuf Updates:
P2P Nodes:
These updates collectively strengthen the staking and registration process while improving integration with the relay and P2P components.
Issue ticket number and link
Fixes # (issue)
Checklist before requesting a review